Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: check whether internal links correspond to a name/id #75

Closed
mikesamuel opened this issue Apr 28, 2019 · 4 comments
Closed
Labels
duplicate This issue was already asked, please comment on the original one

Comments

@mikesamuel
Copy link

Some markdown documents have far more internal fragment links than external. It'd be nice if those could be sanity checked.

// Ideally would error since there is no #foo
markdownLinkCheck(
    `[example](#foo)`,
    (err, results) => { ... })

// No error since there is an explicit name created
markdownLinkCheck(
    `
<a name="foo"> foo </a>

[example](#foo)`,
    (err, results) => { ... })

// No error since there is a link target based on header auto-linking
markdownLinkCheck(
    `
# foo

[example](#foo)`,
    (err, results) => { ... })
@NicolasMassart NicolasMassart added the enhancement New feature request or implementation label Sep 25, 2020
@NicolasMassart
Copy link
Contributor

@mikesamuel Could this issue be merged with #91 in your opinion?

@NicolasMassart NicolasMassart added triage and removed enhancement New feature request or implementation labels Oct 2, 2020
@mikesamuel
Copy link
Author

@NicolasMassart Yes. It looks like Joel's output catches same-document anchors:

[✖] #user-content-query---v3-search-endpoint

@NicolasMassart
Copy link
Contributor

Thanks. Let's say it's a duplicate then (no offense!)

@NicolasMassart NicolasMassart added duplicate This issue was already asked, please comment on the original one and removed triage labels Oct 2, 2020
@mikesamuel
Copy link
Author

@NicolasMassart No offense taken. Thanks for markdown-link-check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue was already asked, please comment on the original one
Projects
None yet
Development

No branches or pull requests

2 participants