E2E : move tchap functions out of element files #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests still pass locally.
Created support/rooms.ts, and started moving tchap funcs into it.
Moving tchap funcs out of support/client.ts, which is copied from element and out of date. Then we can simply import the element version of client.ts and remove the copy (in future PR)
Moving tchap funcs out of room-utils.ts which isn't a cypress file. Cypress files have more boilerplate, but I'd rather have proper cypress funcs than home-made TS utils. It's more cleanly organized, but also it makes clear what functions contain cypress magic. (cypress calls are queued and executed later, which is not the standard js code execution)