Fix cypress login test, to work with cross-signing (locally) #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estellecomment
force-pushed
the
cypress-login-test-with-xsss
branch
from
87c075a to
ddc10b2
Compare
|
Rebasing the branch from the latest default_tchap to make things cleaner. |
estellecomment
changed the title
|
Re-ready for re-review @odelcroi |
odelcroi
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling cross-signing has added a few steps to the login process, which has broken the login test.
This PR
Fixes the test in local run, the CI is currently not functional.