Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: css has gone in About page #694

Closed
odelcroi opened this issue Sep 12, 2023 · 4 comments · Fixed by #697
Closed

Bug: css has gone in About page #694

odelcroi opened this issue Sep 12, 2023 · 4 comments · Fixed by #697
Labels
bug Something isn't working web

Comments

@odelcroi
Copy link
Member

Steps to reproduce

regression due to #618

Capture d’écran 2023-09-12 à 15 38 21

Outcome

What did you expect?

What happened instead?

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

Yes

@odelcroi odelcroi added bug Something isn't working web labels Sep 12, 2023
@odelcroi odelcroi changed the title Bug: css has gone Bug: css has gone in About page Sep 12, 2023
@odelcroi
Copy link
Member Author

@areox-net on a perdu le css lors de l'upgrade :(

@areox-net
Copy link
Contributor

@odelcroi On remarque cela que sur cette page ? Pour info, il me semble qu'il avait pas de custom sur cette page? On dirait plus un comportement different du span qui sert de titre.

Il suffit de mettre cela pour le réparer:

span.mx_SettingsTab_subheading {
    display: block;
    margin-bottom: 4px;
}

@areox-net
Copy link
Contributor

areox-net commented Sep 12, 2023

Ah, c'est vrai que les titres ne sont pas au bon format non-plus. Bizarre.
Où dans les autres page on utilise h2 et h3, ici c'est des div et span. Pas très logique.

@areox-net
Copy link
Contributor

areox-net commented Sep 12, 2023

Après meilleure analyse, c'est ce code qui répare ce bug:

.mx_SettingsTab_heading {
    color: var(--timeline-text-color);
    font-size: 1.5rem;
    font-weight: 600;
    margin-bottom: 10px;
    margin-right: 100px;
    margin-top: 10px;
}
.mx_SettingsTab_subheading {
    color: var(--timeline-text-color);
    display: block;
    font-size: 1rem;
    font-weight: 600;
    margin-bottom: 10px;
    margin-right: 100px;
    margin-top: 12px;
}

@odelcroi odelcroi linked a pull request Sep 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants