Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BuildConfig fields to vector-configs module #830

Closed
giomfo opened this issue Feb 3, 2023 · 0 comments
Closed

Move BuildConfig fields to vector-configs module #830

giomfo opened this issue Feb 3, 2023 · 0 comments
Labels

Comments

@giomfo
Copy link
Contributor

giomfo commented Feb 3, 2023

Element avoids the direct usage of BuildConfig fields since the version v1.4.32 (related PR)
The goal of this request is to do the same for Tchap by moving all the build configs and resource configs to the dedicated module vector-configs.

Doing that, we have more flexibility to override some config in the unit tests and centralize it in a single place (making it easier to track)

Note: a PR has been already started :#717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant