Deprecate Array<'a, T>::as_slice
#672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces pgx::Layout (with Size and Align types composing it), parallel to std::alloc::Layout, but modified to allow describing the Postgres layouts instead. Some of the constants in this implementation are recently #defined. We can simply polyfill simple constants and structs in Postgres 10-12, to make binding against Postgres slightly easier in pgx itself. This should be done more cautiously for functions and the like.
This was referenced Sep 6, 2022
Closed
|
I had to add several tests to feel confident merging this but I feel it is ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks the formal beginning of the deprecation process for the
Array<'_, T>::as_slicefunction. As currently implemented, it cannot be safe without inducing at minimum these panics, which means it must beunsafe, which would already be a breaking change to introduce. And this does not actually make it fully correct, either, but we can expect code "in the wild" probably exercises this function as it is fairly idiomatic to use in Rust, so removing it abruptly without offering these directions would make the upgrade path for 0.5.0 even more annoying.I expect we can introduce a new variant of this function in the future which offers a very similar interface and is either safe or
unsafe(and arguably RawArray offers theunsafeversion already), but I expect that to not happen before 0.6.1 or 0.7.0, as it involves some fairly sweeping structural changes in PGX.