-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce feature flagging for time crate #664
Conversation
For reference, this feature flag doesn't break any user's API as the flagged impls were introduced during |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PGX has optional feature flags for Rust code that do not involve configuring the version of Postgres used, | ||
but rather extend additional support for other kinds of Rust code. These are not included by default. | ||
|
||
### "time-crate": interop with the `time` crate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name works for me. Good job finding a name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything here looks great!
Will this impact builds/testing/CI that much? Or will it only affect how pgx is built for version 0.5.0-beta.0?
I don't think it will have much of an impact in practice, since we enable it in pgx-tests. |
This complements the deprecation process that has already begun by allowing us to make this crate an optional dependency in a future version of PGX.