Refactor to use NonNull in datum::Array #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows removing the Options from the NonNull ptrs internally, which will make the result more sound in the long run.
Hoverbear
approved these changes
Aug 26, 2022
workingjubilee
commented
Aug 26, 2022
Comment on lines
96
to
97
| elements: *mut pg_sys::Datum, | ||
| nulls: *mut bool, |
There was a problem hiding this comment.
These are being kept as-is for the moment because the actual fix for them is using the new RawArray abstraction plus bitvec to handle things, removing usage of deconstruct_array, and that's a more complex followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a small but, IMO, pointless
panic!in our exposed call surface. It is not unsafe to return the null pointer. That's whyptr::null()is safe to call.panic!should be used to avoid unsafe or invalid conditions, not just undesirable ones.This also begins the deprecation process for
Array::over.