Input functions should take Option #646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contrasts with PR 641. The primary motivation here is that the various input functions take optional arguments, and produce optional results. This is implemented by changing the interface in
pgx/src/inoutfuncs.rs
, then the macro inpgx-macros/src/lib.rs
, then teaching the SQL generator that this is acceptable inpgx/src/datum/mod.rs
. Finally, I changed all the implementations of those functions that I could find, so thatcargo test --workspace
passes with these changes.