Hash functions correctly depend on _eq functions #637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a function is marked with
#[derive(PostgresHash, ...)]
SQL code like the following is generated:However, in the pgx schema DAG, there is no dependency currently emitted between the
OPERATOR CLASS
and thefoo_eq
function (or theOPERATOR =
associated with it). This means about half the time, the hash stuff is generated before the definition of equals, which means the extension will fail to install.This merge request adds a dependency to the DAG, causing the equals function to always be emitted before the hash function. Closes #611 .