Fix unsound interaction between Array::over and Drop
#634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests reveal an unsoundness caused by implicit drop of Arrays, when the Drop implementation is called, causing pfree to be called.
Memory leak, shmemory leak. If we double free, we're in for much worse than a leak.
This pointer might actually prove important at some point, as it points back to the original, pre-detoasting varlena. More analysis is required before we ditch it.
|
cc @mhov you may be interested in knowing about the other problems with the array type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #633.
It also partially addresses #631 (i.e. for this type).
It introduces a new problem (leaking arrays) that I hope to fix soon,
as part of trying to fix, in the future, #627.