Support normative change to Resizable ArrayBuffer #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent normative change to the Resizable ArrayBuffer modified the criteria for a TypedArray becoming "out of bounds." Following the change, TypedArrays which track the length of their underlying ArrayBuffer instance are no longer considered "out of bounds" when the ArrayBuffer is resized such that its size matches the TypedArray's offset exactly. tc39/proposal-resizablearraybuffer#70 The majority of this patch's changes extend coverage to include cases for both "on boundary" and "out of bounds" without reflecting any new semantics. Two changes describe observable differences in the new version of the algorithm: - out-of-bounds-when-species-retrieved-different-type.js - out-of-bounds-when-species-retrieved-same-type.js
rwaldron
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent normative change to the Resizable ArrayBuffer modified the
criteria for a TypedArray becoming "out of bounds." Following the
change, TypedArrays which track the length of their underlying
ArrayBuffer instance are no longer considered "out of bounds" when the
ArrayBuffer is resized such that its size matches the TypedArray's
offset exactly.
tc39/proposal-resizablearraybuffer#70
The majority of this patch's changes extend coverage to include cases
for both "on boundary" and "out of bounds" without reflecting any new
semantics. Two changes describe observable differences in the new
version of the algorithm:
/cc @marjakh