Skip to content

Commit

Permalink
Add Tests for ECMA402 PR811
Browse files Browse the repository at this point in the history
Add tests to check the order of option readings and output
keys in resolvedOptions of Intl.NumberFormat and PluralRules.
  • Loading branch information
FrankYFTang committed Sep 9, 2023
1 parent 1db9a49 commit 00d7ff5
Show file tree
Hide file tree
Showing 4 changed files with 111 additions and 0 deletions.
36 changes: 36 additions & 0 deletions test/intl402/NumberFormat/constructor-option-read-order.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
/// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-initializenumberformat
description: Checks the order of option read.
features: [Intl.NumberFormat-v3]
---*/

let optionKeys = Object.keys((new Intl.NumberFormat()).resolvedOptions());
let opt = {};
let readKeys = new Array();
// For each item returned by resolvedOptions of default, add a getter
// to track the reading order.
optionKeys.forEach((property) =>
Object.defineProperty(opt, property, {
get() {
readKeys[readKeys.length] = property;
return undefined;
},
}));
let p = new Intl.NumberFormat(undefined, opt);
assert.sameValue(
'numberingSystem,' +
'style,' +
'notation,' +
'minimumIntegerDigits,' +
'minimumFractionDigits,' +
'maximumFractionDigits,' +
'roundingIncrement,' +
'roundingMode,' +
'roundingPriority,' +
'trailingZeroDisplay,' +
'useGrouping,' +
'signDisplay',
readKeys.toString());
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-intl.numberformat.prototype.resolvedoptions
description: order of property keys for the object returned by resolvedOptions()
features: [Intl.NumberFormat-v3]
---*/

assert.sameValue(
'locale,' +
'numberingSystem,' +
'style,' +
'minimumIntegerDigits,' +
'minimumFractionDigits,' +
'maximumFractionDigits,' +
'useGrouping,' +
'notation,' +
'signDisplay,' +
'roundingIncrement,' +
'roundingMode,' +
'roundingPriority,' +
'trailingZeroDisplay',
Object.keys((new Intl.NumberFormat()).resolvedOptions()).toString());
32 changes: 32 additions & 0 deletions test/intl402/PluralRules/constructor-option-read-order.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
/// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.

/*---
esid: sec-initializepluralrules
description: Checks the order of option read.
features: [Intl.NumberFormat-v3]
---*/

let optionKeys = Object.keys((new Intl.PluralRules()).resolvedOptions());
let opt = {};
let readKeys = new Array();
// For each item returned by resolvedOptions of default, add a getter
// to track the reading order.
optionKeys.forEach((property) =>
Object.defineProperty(opt, property, {
get() {
readKeys[readKeys.length] = property;
return undefined;
},
}));
let p = new Intl.PluralRules(undefined, opt);
assert.sameValue(
'type,' +
'minimumIntegerDigits,' +
'minimumFractionDigits,' +
'maximumFractionDigits,' +
'roundingIncrement,' +
'roundingMode,' +
'roundingPriority,' +
'trailingZeroDisplay',
readKeys.toString());
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// Copyright 2023 the V8 project authors. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-intl.pluralrules.prototype.resolvedoptions
description: order of property keys for the object returned by resolvedOptions()
features: [Intl.NumberFormat-v3]
---*/

assert.sameValue(
'locale,' +
'type,' +
'minimumIntegerDigits,' +
'minimumFractionDigits,' +
'maximumFractionDigits,' +
'pluralCategories,' +
'roundingIncrement,' +
'roundingMode,' +
'roundingPriority,' +
'trailingZeroDisplay',
Object.keys((new Intl.PluralRules()).resolvedOptions()).toString());

0 comments on commit 00d7ff5

Please sign in to comment.