-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
size-suggestion: Consider merging three Calendar.p.*FromFields
methods into one
#2851
Comments
I'd much prefer separate methods to combined parameterized methods, which are inherently less approachable and more complex. |
If we did end up keeping the Calendar protocol in roughly its current form, I'd be OK with this. It's less ergonomic, but that's something we've decided is OK for custom calendar use cases. It would make the builtin implementations of |
be aware when I suggest this, it is part of a bigger counterproposal to issues/2854
|
Meeting 2024-05-23: In #2854, we're proposing removing the Temporal.Calendar class and protocol, so this issue doesn't apply to Temporal V1. However, there is wide interest in creating a follow-up proposal to enable custom calendars, and the ideas proposed in this issue seem like simpler and more efficient solution than the current custom calendar design. Anyone working on a future custom calendar proposal should refer to this issue for inspiration. |
With #2854 approved, this issue no longer applies. |
If we don't remove
Temporal.Calendar
in #2826, should we reduce its method count by two by mergingdateFromFields
,monthDayFromFields
,yearMonthFromFields
into a singlefromFields
method that accepts akind
parameter to determine the desired output type?This issue is adapted from suggestions made by @FrankYFTang to help reduce the size of Temporal to address concerns from implementers (especially Android and Apple Watch) that Temporal's install size and/or in-memory size is too large.
The text was updated successfully, but these errors were encountered: