Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup issue about custom time zones #1037

Closed
justingrant opened this issue Oct 22, 2020 · 1 comment
Closed

Rollup issue about custom time zones #1037

justingrant opened this issue Oct 22, 2020 · 1 comment

Comments

@justingrant
Copy link
Collaborator

There are several open issues related to custom time zones. I think it might be easier to discuss all of these issues together because the answer to one might influence our decision on the others. LMK if I missed any.

  1. Must ZonedDateTime.prototype.timeZone be a TimeZone? Or can it be a TimeZoneProtocol with some TimeZone properties and methods not implemented? If the latter, how to address the usability concerns outlined in Conflict between docs and polyfill for cloning using TimeZone.from and Calendar.from #810 (comment)?
  1. Does TimeZone.from always clone the input, or are there cases where it will return the same input back to the user? If "same input back" then is this an SES concern? Conflict between docs and polyfill for cloning using TimeZone.from and Calendar.from #810

  2. Can custom time zones be plain objects or must they inherit from TimeZone? If "must inherit" then how do we handle cross-realm cases noted by @gibson042 (FYI - @littledan had questions about this in How to handle this code? Temporal.TimeZone.from({timeZone: 'Asia/Tokyo'}) #925 (comment))

  3. How do the answers above vary (if at all) for custom calendars vs. custom time zones?

@ptomato
Copy link
Collaborator

ptomato commented Oct 22, 2020

I think we can close this one in favour of #1040/#1041.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants