This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Fix two issues and clean up #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
suggested changes
May 6, 2017
package.json
Outdated
| @@ -41,7 +41,7 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "foreach": "^2.0.5", | |||
| "ecmarkup": "^2.8.1", | |||
| "ecmarkup": "^3.11.2", | |||
There was a problem hiding this comment.
I'd prefer not to use a version of a tool that drops support for LTS versions of node; let's stick with v2 if v3's dropped node 4 support.
ljharb
reviewed
May 6, 2017
spec.html
Outdated
| @@ -4,94 +4,94 @@ | |||
| contributors: Jordan Harband | |||
| </pre> | |||
| <emu-clause id="String.prototype.matchAll"> | |||
| <h1>String.prototype.matchAll ( regexp )</h1> | |||
There was a problem hiding this comment.
I've intentionally used tabs in this repo; please revert.
ljharb
force-pushed
the
master
branch
3 times, most recently
from
16caadd to
e35d0ed
Compare
Additionally, modernize spec text generally Closes tc39#2
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lacks a polyfill update.