Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention XRegExp #4

Open
h-h-h-h opened this issue Jun 1, 2022 · 2 comments
Open

Mention XRegExp #4

h-h-h-h opened this issue Jun 1, 2022 · 2 comments

Comments

@h-h-h-h
Copy link

h-h-h-h commented Jun 1, 2022

Shouldn't XRegExp be mentioned under "Prior Art"?

@rbuckton
Copy link
Collaborator

rbuckton commented Jun 5, 2022

I don't think Prior Art needs to list every existing implementation, but I can look into adding it.

@slevithan
Copy link

slevithan commented Jun 19, 2022

I'm the creator of XRegExp. No need to add it unless you find it helpful to do so, but for what it's worth, XRegExp is a JavaScript library that converts extended regex syntax into native regexes and has supported the x flag (along with line comments and inline comments, which are also mentioned here) since ~2007.

One thing the XRegExp docs call out that I don't currently see mentioned in this proposal is the two potential meanings of describing whitespace with x as "insignificant":

It might be better to think of whitespace and comments as do-nothing (rather than ignore-me) metacharacters. This distinction is important with something like \12 3, which with the x flag is taken as \12 followed by 3, and not \123. However, quantifiers following whitespace or comments apply to the preceding token, so x + is equivalent to x+.

BTW, I'm excited to see this proposal and hope it progresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants