Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should new Proxy get a third argument as well? #6

Closed
ajvincent opened this issue Mar 16, 2022 · 1 comment
Closed

Should new Proxy get a third argument as well? #6

ajvincent opened this issue Mar 16, 2022 · 1 comment

Comments

@ajvincent
Copy link
Collaborator

No description provided.

@ajvincent ajvincent mentioned this issue Mar 17, 2022
Closed
@ajvincent
Copy link
Collaborator Author

I think the answer should be yes. When that third argument is available but missing, the default behavior doesn't change. Since new Proxy doesn't have more than two arguments right now, we should reasonably expect people aren't using a third argument...

Ultimately, I think it's safe to add revocation by the third argument's signal property.

@ajvincent ajvincent mentioned this issue Apr 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ajvincent