This repository has been archived by the owner on Oct 8, 2024. It is now read-only.
fixes #115: @@toStringTag is writable now #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I appreciate the thumbs-ups, I actually need an approving review here to merge. Feedback from committee was to make this property writable. |
bakkot
approved these changes
Sep 14, 2022
> Every other data property described in clauses 19 through 28 and in
> Annex B.2 has the attributes { [[Writable]]: true, [[Enumerable]]:
> false, [[Configurable]]: true } unless otherwise specified.
|
I've updated the PR to just remove the description of the property descriptor properties since
and these |
|
Per @bakkot's request, I've added a note anyway. |
bakkot
approved these changes
Sep 15, 2022
2767mr
pushed a commit
to 2767mr/graaljs
that referenced
this pull request
Sep 16, 2022
2767mr
pushed a commit
to 2767mr/graaljs
that referenced
this pull request
Sep 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115. Option 2: just make
@@toStringTagwritable.