Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source phase terminology #35

Merged
merged 5 commits into from
Mar 22, 2023
Merged

Source phase terminology #35

merged 5 commits into from
Mar 22, 2023

Conversation

guybedford
Copy link
Collaborator

Renames the proposal to "Module Source Imports", using the terminology of this being a module phase as opposed to using the reflection term.

Syntax is updated from import module x from 'x' to import source x from 'x' using the phase attribute for dynamic import.

Cross-references are updated accordingly.

@Jack-Works
Copy link
Member

sorry, can you clarify the term we're using now? I'm a bit confused.

  • unparsed file: asset
  • parsed but unlinked module (can link manually): ?
  • parsed and linked module (can feed to importHook): ?
  • executed module: normal import

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jack-Works I'll explain at plenary - will update the readme after

@guybedford guybedford merged commit f833982 into main Mar 22, 2023
@guybedford guybedford deleted the source-phase branch March 22, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants