Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

fixes #54: only perform IsArray test when depth > 0 #55

Merged
merged 1 commit into from
Jan 18, 2018
Merged

fixes #54: only perform IsArray test when depth > 0 #55

merged 1 commit into from
Jan 18, 2018

Conversation

michaelficarra
Copy link
Member

Fixes #54. @evilpie @anba Please review.

ljharb
ljharb approved these changes Jan 17, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems unfortunate to make the algorithm more complex here, but this is straightforward.

@michaelficarra michaelficarra merged commit 0cc56eb into master Jan 18, 2018
@michaelficarra michaelficarra deleted the michaelficarra-patch-1 branch January 18, 2018 02:41
zloirock added a commit to zloirock/core-js that referenced this pull request Jan 18, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
eb5c36c
ljharb added a commit to ljharb/Array.prototype.flatMap that referenced this pull request Jan 18, 2018
@ljharb
[Refactor] adjust shouldFlatten logic
6c84d1e 
Per tc39/proposal-flatMap#55
ljharb added a commit to ljharb/Array.prototype.flat that referenced this pull request Jan 18, 2018
@ljharb
[Refactor] adjust shouldFlatten logic
a56bece 
Per tc39/proposal-flatMap#55
zloirock added a commit to zloirock/core-js that referenced this pull request Jan 24, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
9f1d17d
zloirock added a commit to zloirock/core-js that referenced this pull request Feb 6, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
47709e8
zloirock added a commit to zloirock/core-js that referenced this pull request Feb 16, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
4117c48
zloirock added a commit to zloirock/core-js that referenced this pull request Feb 27, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
dc6ce24
zloirock added a commit to zloirock/core-js that referenced this pull request Mar 15, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
fd51002
zloirock added a commit to zloirock/core-js that referenced this pull request Mar 17, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
1e3b764
zloirock added a commit to zloirock/core-js that referenced this pull request Mar 27, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
ade5da9
zloirock added a commit to zloirock/core-js that referenced this pull request Mar 27, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
a3cba7d
zloirock added a commit to zloirock/core-js that referenced this pull request Apr 3, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
b9bacb9
zloirock added a commit to zloirock/core-js that referenced this pull request Apr 9, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
416206a
zloirock added a commit to zloirock/core-js that referenced this pull request Apr 21, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
ed16c28
zloirock added a commit to zloirock/core-js that referenced this pull request May 4, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
e346f79
zloirock added a commit to zloirock/core-js that referenced this pull request May 5, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
9f4da13
zloirock added a commit to zloirock/core-js that referenced this pull request May 7, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
0d25e1d
zloirock added a commit to zloirock/core-js that referenced this pull request May 14, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
3087e6d
zloirock added a commit to zloirock/core-js that referenced this pull request May 18, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
9045c35
zloirock added a commit to zloirock/core-js that referenced this pull request May 26, 2018
@zloirock
update Array#{flatten, flatMap} per tc39/proposal-flatMap#55
fb31425
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anba anba anba approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelficarra @ljharb @anba