Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

One more modified function: FunctionAllocate #124

Closed
spectranaut opened this issue Feb 7, 2018 · 2 comments
Closed

One more modified function: FunctionAllocate #124

spectranaut opened this issue Feb 7, 2018 · 2 comments

Comments

@spectranaut
Copy link

spectranaut commented Feb 7, 2018

Hi @domenic,

In AsyncGeneratorFunction line 3:

3. Return ? CreateDynamicFunction(C, NewTarget, "async generator", args). 

FunctionAllocate is called with parameter functionKind = "async generator". FunctionAllocate needs one small modification (this function is currently not in the spec proposal):

2. Assert: functionKind is either "normal", "non-constructor", "generator", "async", or "async generator".
@domenic
Copy link
Member

domenic commented Feb 7, 2018

Thanks for the find! Probably best to note this in tc39/ecma262#1066 as that's where the normative text for this has been moved to.

@bterlson
Copy link
Member

I made this change in tc39/ecma262#1066. I'll go ahead and close this now. Thank you @spectranaut!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants