-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better errors #226
Comments
Thinking about this some: I'd like to use the same format for other errors as we do for linting errors. Those errors are not identified until later in the pipeline. But the eslint error formatters don't support streaming: specifically, they always add a "1 error found." summary at the end, which would be weird to see multiple times. I'm not entirely sure how to handle it. Here's some possibilities, in roughly descending order of how much I like them
Maybe there's some other alternative? Edit: went with another alternative, which is to just print errors twice: a quick summary when encountered and, if using |
For example, having multiple linebreaks in a
<p>
should not abort the build with "Error: expecting EOF, got parabreak".At the very least we need to start wrapping those and providing location information, because the errors at the moment are totally useless. But also we should clean up the output to suggest what's actually wrong. And in the above case it shouldn't be a hard error at all, just a lint warning.
The text was updated successfully, but these errors were encountered: