Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in ClassDefinitionEvaluation #2645

Closed
bakkot opened this issue Jan 31, 2022 · 0 comments · Fixed by #2547
Closed

bug in ClassDefinitionEvaluation #2645

bakkot opened this issue Jan 31, 2022 · 0 comments · Fixed by #2547
Labels
spec bug

Comments

@bakkot
Copy link
Contributor

bakkot commented Jan 31, 2022

Step 31.b.ii is

ii. Let result be ? Call(elementRecord.[[BodyFunction]], F).

That ? is stray - on the next line we check for abrupt completions so we can fix up the PrivateEnvironment. The ? prevents us from getting there, so the PrivateEnvironment ends up wrong.

Fix is to just remove the ?. We'll do that as part of #2547.
@bakkot bakkot added the editor call to be discussed in the next editor call label Jan 31, 2022
@michaelficarra michaelficarra mentioned this issue Jan 31, 2022
Merged
23 tasks
@michaelficarra michaelficarra added spec bug and removed editor call to be discussed in the next editor call labels Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
spec bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: remove implicit wrapping/unwrapping of completion records tc39/ecma262
2 participants
@michaelficarra @bakkot