Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug? re lookbehind assertions in Annex B #1674

Closed
jmdyck opened this issue Aug 21, 2019 · 1 comment · Fixed by #1675
Closed

bug? re lookbehind assertions in Annex B #1674

jmdyck opened this issue Aug 21, 2019 · 1 comment · Fixed by #1675
Labels

Comments

@jmdyck
Copy link
Collaborator

jmdyck commented Aug 21, 2019

When lookbehind assertions were introduced in bf8a9be (PR #1029), there was no change to Annex B.

Later, e5b6605 (PR #1102) added lookbehind assertions to the 'Assertion' production in Annex B.

However, I think Annex B needs one more collateral change. The original PR added the direction parameter to the evaluate semantics for Disjunction, Alternative, Term, Atom, and AtomEscape, and also added it to the parameter list for CharacterSetMatcher. Annex B picks up most of these changes implicitly, but I believe it needs to add the _direction_ parameter to the calls to CharacterSetMatcher in the two evaluation rules for ExtendedAtom.

Attn @mathiasbynens, @littledan, @claudepache, @IgnoredAmbience ?

@mathiasbynens
Copy link
Member

Yeah, that makes sense to me. Thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants