Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: tc39/ecma262
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2c542b30c80125d6b5df40c21d4901c3c4c29eac
Choose a base ref
..
head repository: tc39/ecma262
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c8482efd9f80b09c02f939ca0fe0c0bfb332db3c
Choose a head ref
Showing with 2,459 additions and 2,283 deletions.
  1. +1 −1 .github/workflows/build.yml
  2. +1 −1 .github/workflows/deploy.yml
  3. +17 −0 .github/workflows/enforce-format.yml
  4. +3 −1 .github/workflows/preview.yml
  5. +1 −1 CONTRIBUTING.md
  6. +207 −97 package-lock.json
  7. +7 −6 package.json
  8. +2,222 −2,176 spec.html
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -14,4 +14,4 @@ jobs:
with:
node-version: lts/*
use-npm-ci: true
- run: npm run build-master
- run: npm run build-head
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ name: 'ecma-262 deploy'
on:
push:
branches:
- master
- main

jobs:
deploy:
17 changes: 17 additions & 0 deletions .github/workflows/enforce-format.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: 'enforce format'

on: [pull_request]

jobs:
build:
name: 'enforce format'
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
- uses: ljharb/actions/node/install@56f291b2a0d9e3bce72634356ae949b1e054b9f8
name: 'nvm install lts/* && npm ci'
with:
node-version: lts/*
use-npm-ci: true
- run: 'if ! $(npm bin)/emu-format --check spec.html; then echo "You need to run `npm run format`"; exit 1; fi'
4 changes: 3 additions & 1 deletion .github/workflows/preview.yml
Original file line number Diff line number Diff line change
@@ -49,7 +49,9 @@ jobs:
with:
script: |
console.log(${{ toJson(github.event) }});
- run: echo "PULL_REQUEST=$(cat out/pr.txt)" >> $GITHUB_ENV
- run: head -n1 out/pr.txt | grep -e '^[1-9][0-9]*$'
name: 'validate PR number from archive'
- run: echo "PULL_REQUEST=$(head -n1 out/pr.txt)" >> $GITHUB_ENV
- run: rm out/pr.txt && echo $PULL_REQUEST
- run: node scripts/publish-preview
env:
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ Commits in pull requests should have a first line which starts with a tag, follo
* Markup: non-visible changes to markup in the spec
* Meta: changes to documents about this repository (e.g. readme.md or contributing.md) and other supporting documents or scripts (e.g. `package.json`, design documents, etc.)

If changes in the upstream `master` branch cause your PR to have conflicts, you should rebase your branch to `master` and force-push it to your repo (rather than doing a merge commit).
If changes in the upstream `main` branch cause your PR to have conflicts, you should rebase your branch to `main` and force-push it to your repo (rather than doing a merge commit).

Issues and PRs in the ecma262 repository are appropriate for minor modifications to the existing specification, for example to make behavior more consistent in an edge case, match what is implemented by the large majority of actual implementations, or to clarify wording. New features use the feature request process described below.

Loading