Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Has this been merged upstream? #14

Open
alerque opened this issue May 11, 2019 · 4 comments
Open

Has this been merged upstream? #14

alerque opened this issue May 11, 2019 · 4 comments

Comments

@alerque
Copy link

alerque commented May 11, 2019

I ran across this repository and thought "oh cool, better Lua syntax highlighting!". I installed it and nothing happened. Then I started checking the comparison in the readme and realized I already have the improvements there. Was this merged into vim and/or neovim upstream? (I'm running Neovim.)

If so its probably worth mentioning that in the README.

@alerque alerque changed the title Has this been merged upstream Has this been merged upstream? May 11, 2019
@averms
Copy link

averms commented Apr 28, 2020

No it has not been merged upstream to either Vim or Neovim (Neovim uses the same runtime files). Try using @type in a comment with and without this plugin.

@alerque
Copy link
Author

alerque commented Apr 29, 2020

@a-vrma I'm running Neovim without this plugin. Using the -- @type thing in a comment in Lua I get special highlighting of the @type keyword. Looking at the with/without screenshot in this project's readme my view looks more like the 'with' version. My colorscheme is different of course but as far as I can tell all of the things that are plain unhighlighted strings in the 'without' shot but highlighted in the 'with' shot are highlighted in my nvim. Hence the question here. Maybe not this project in specific, but the baseline Lua support seems to have improved dramatically and I was wondering if this project had anything to offer still or was obsolete (or perhaps even a regression).

@averms
Copy link

averms commented Apr 29, 2020

Oh wow im not getting that on neovim stable. Maybe another plugin or lsp?

@alerque
Copy link
Author

alerque commented Apr 29, 2020

@a-vrma It's possible, but it's not immediately obvious to me what plugin I have that might be doing that. You can see the ones I have loaded in my init.vim.

.... NEVERMIND. It is vim-polyglot which does in fact use this plugin's syntax.

In that case I would re-purpose this issue to suggest contributing this syntax upstream. There is no excuse for how bad the default is when this version is lying around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants