Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] ask & confirm Dialog returns true in all cases #8399

Closed
martin-opensky opened this issue Dec 14, 2023 · 3 comments
Closed

[bug] ask & confirm Dialog returns true in all cases #8399

martin-opensky opened this issue Dec 14, 2023 · 3 comments
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@martin-opensky
Copy link

Describe the bug

For the 'ask' and 'confirm' dialogs the response is always true

Reproduction

The code from line 34 - 53 in this file covers the issue: https://github.com/martin-opensky/create-tauri-2-next-14-app/blob/tauri-alpha-bug-1/src/components/ActionBar.tsx

In all cases the response is true.

Expected behavior

The expected behaviour would be:

  • Confirm: cancel is false, ok is true
  • Ask: No is false, Yes is true

Platform and versions

[✔] Environment
    - OS: Mac OS 14.1.2 X64
    ✔ Xcode Command Line Tools: installed
    ✔ rustc: 1.74.1 (a28077b28 2023-12-04)
    ✔ cargo: 1.74.1 (ecb9851af 2023-10-18)
    ✔ rustup: 1.26.0 (5af9b9484 2023-04-05)
    ✔ Rust toolchain: stable-aarch64-apple-darwin (default)
    - node: 20.5.1
    - pnpm: 8.6.3
    - yarn: 1.22.19
    - npm: 9.8.0

[-] Packages
    - tauri [RUST]: 2.0.0-alpha.18
    - tauri-build [RUST]: 2.0.0-alpha.12
    - wry [RUST]: 0.34.2
    - tao [RUST]: 0.23.0
    - @tauri-apps/api [NPM]: 2.0.0-alpha.12
    - @tauri-apps/cli [NPM]: 2.0.0-alpha.18

[-] App
    - build-type: bundle
    - CSP: unset
    - distDir: ../dist
    - devPath: http://localhost:3000/
    - framework: React (Next.js)
    - bundler: Vite

Stack trace

No response

Additional context

No response

@martin-opensky martin-opensky added status: needs triage This issue needs to triage, applied to new issues type: bug labels Dec 14, 2023
@amrbashir
Copy link
Member

amrbashir commented Dec 14, 2023

I think this is a duplicate of tauri-apps/plugins-workspace#711 and so has been fixed in tauri-apps/plugins-workspace#769 and will be available in the next release.

@martin-opensky
Copy link
Author

@amrbashir Thanks for the quick response. Whats the best channel to keep up to date with minor releases related to Tauri v2? So I can see when this has been pushed?

@amrbashir
Copy link
Member

I'd say just subscribe to releases notifications on tauri and plugins-workspace repos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

No branches or pull requests

2 participants