Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] publisher field not working with NSIS target #6870

Closed
dubisdev opened this issue May 5, 2023 · 1 comment · Fixed by #6693
Closed

[bug] publisher field not working with NSIS target #6870

dubisdev opened this issue May 5, 2023 · 1 comment · Fixed by #6693
Labels
platform: Windows scope: bundler The bundler used in our cli to make installers status: needs triage This issue needs to triage, applied to new issues type: bug

Comments

@dubisdev
Copy link

dubisdev commented May 5, 2023

Describe the bug

When bundling for Windows, the msi package uses the publisher field of the config file but the NSIS package does not.

tauri.conf.json

{
  ...
  "tauri": {
    ...
    "bundle": {
      ...
      "publisher": "dubis.dev",
      "identifier": "dev.dubis.runmath",
      "targets": [
        "msi",
        "nsis"
      ]
    },
    ...
}

Results:

⬇️ MSI
image
🔼 NSIS

Reproduction

No response

Expected behavior

Both fields should be the same

Platform and versions

[✔] Environment
    - OS: Windows 10.0.22621 X64
    ✔ WebView2: 112.0.1722.68
    ✔ MSVC: Visual Studio Build Tools 2022
    ✔ rustc: 1.66.0 (69f9c33d7 2022-12-12)
    ✔ Cargo: 1.66.0 (d65d197ad 2022-11-15)
    ✔ rustup: 1.25.1 (bb60b1e89 2022-07-12)
    ✔ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
    - node: 18.14.2
    - pnpm: 8.2.0
    - yarn: 1.22.19
    - npm: 9.6.6

[-] Packages
    - tauri [RUST]: 1.3.0
    - tauri-build [RUST]: 1.3.0
    - wry [RUST]: 0.24.1
    - tao [RUST]: git+https://github.com/tauri-apps/tao?branch=v0.16#ed6aab6b1226e56683798732ad01bf3f4658097e (0.16.0)
    - @tauri-apps/api [NPM]: 1.3.0
    - node: 18.14.2
    - pnpm: 8.2.0
    - yarn: 1.22.19
    - npm: 9.6.6

[-] Packages
    - tauri [RUST]: 1.3.0
    - tauri-build [RUST]: 1.3.0
    - wry [RUST]: 0.24.1
    - tao [RUST]: git+https://github.com/tauri-apps/tao?branch=v0.16#ed6aab6b1226e56683798732ad01bf3f4658097e (0.16.0)
    - @tauri-apps/api [NPM]: 1.3.0
    - @tauri-apps/cli [NPM]: 1.3.0

[-] App

Stack trace

No response

Additional context

No response

@dubisdev dubisdev added status: needs triage This issue needs to triage, applied to new issues type: bug labels May 5, 2023
@FabianLars FabianLars added platform: Windows scope: bundler The bundler used in our cli to make installers labels May 5, 2023
@amrbashir
Copy link
Member

should be fixed by #6693

@amrbashir amrbashir linked a pull request May 5, 2023 that will close this issue
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows scope: bundler The bundler used in our cli to make installers status: needs triage This issue needs to triage, applied to new issues type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants