From 5b4d5e75ff73a4bdc526b5e436561fe323e96a2d Mon Sep 17 00:00:00 2001 From: Amr Bashir Date: Sat, 17 Jun 2023 14:11:21 +0300 Subject: [PATCH] fix(core): revert #6680, remove default notification sound on Windows ref: #7210 --- .changes/core-revet-windows-notification-default-sound.md | 5 +++++ core/tauri/src/api/notification.rs | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) create mode 100644 .changes/core-revet-windows-notification-default-sound.md diff --git a/.changes/core-revet-windows-notification-default-sound.md b/.changes/core-revet-windows-notification-default-sound.md new file mode 100644 index 000000000000..6a347b884ea9 --- /dev/null +++ b/.changes/core-revet-windows-notification-default-sound.md @@ -0,0 +1,5 @@ +--- +'tauri': 'patch' +--- + +Revert [#6680](https://github.com/tauri-apps/tauri/pull/6680) which added a default sound for notifications on Windows. This introduced inconsistency with other platforms that has silent notifications by default. In the upcoming releases, we will add support for modifying the notification sound across all platforms. diff --git a/core/tauri/src/api/notification.rs b/core/tauri/src/api/notification.rs index aaf9249339b4..8110f52ddf64 100644 --- a/core/tauri/src/api/notification.rs +++ b/core/tauri/src/api/notification.rs @@ -119,9 +119,6 @@ impl Notification { { notification.app_id(&self.identifier); } - - // will be parsed as a `::winrt_notification::Sound` - notification.sound_name("Default"); } #[cfg(target_os = "macos")] {