From 59ceb94dbc826f7273c2d8131443521a303b42f9 Mon Sep 17 00:00:00 2001 From: YoggieS <61660055+yoggys@users.noreply.github.com> Date: Mon, 21 Oct 2024 18:05:22 +0200 Subject: [PATCH 1/2] fix: docs of select --- plugins/sql/guest-js/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/sql/guest-js/index.ts b/plugins/sql/guest-js/index.ts index 05eed0e3a..e200936e5 100644 --- a/plugins/sql/guest-js/index.ts +++ b/plugins/sql/guest-js/index.ts @@ -129,12 +129,12 @@ export default class Database { * ```ts * // for sqlite & postgres * const result = await db.select( - * "SELECT * from todos WHERE id = $1", id + * "SELECT * from todos WHERE id = $1", [ id ] * ); * * // for mysql * const result = await db.select( - * "SELECT * from todos WHERE id = ?", id + * "SELECT * from todos WHERE id = ?", [ id ] * ); * ``` */ From 37afb458b265c9d27ad4439eabfd3b290f83c29c Mon Sep 17 00:00:00 2001 From: YoggieS <61660055+yoggys@users.noreply.github.com> Date: Wed, 23 Oct 2024 12:30:40 +0200 Subject: [PATCH 2/2] Create change-pr-1963.md --- .changes/change-pr-1963.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changes/change-pr-1963.md diff --git a/.changes/change-pr-1963.md b/.changes/change-pr-1963.md new file mode 100644 index 000000000..ce68f4e22 --- /dev/null +++ b/.changes/change-pr-1963.md @@ -0,0 +1,5 @@ +--- +"sql-js": patch +--- + +Fixed incorrect documentation of the select method in the Database class.