Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change backlog #107

Open
1 of 8 tasks
LTLA opened this issue Jul 8, 2024 · 0 comments
Open
1 of 8 tasks

Breaking change backlog #107

LTLA opened this issue Jul 8, 2024 · 0 comments

Comments

@LTLA
Copy link
Member

LTLA commented Jul 8, 2024

  • Turn the isometric helpers into proper interfaces with all template parameters at the class level. This provides the option to avoid repeated compilation of multiple realized templates for each template type.
  • Remove the isometric make helpers, people need to specify almost all the template parameters manually anyway.
  • Isometric helpers should have a way of specifying the expected dimensions of the matrix they are applied to, e.g., to ensure that the vectors are of the right length.
  • Remove all default template arguments, people should stop being wimps.
  • Replace default function arguments (e.g., in convert_to_sparse) with an Options class and make an overload that uses the default Options.
  • All interface functions should now accept references instead of pointers, which is nicer for everyone.
  • Remove the delayed bind/transpose helpers as we can just call the constructors directly.
  • Add final to all subclass declarations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant