[Bug]: Throw error in GET list have parameter include is categories or menus #66

BaoNguyenSE · 2022-01-18T04:33:07Z

What happened?

version use: v1.3.2

any api index have param include relationship one to many
ex: categories, menus,...

What did you expect to happen?

this return list relationship

Version

3.1.x

What browser are you seeing the problem on?

No response

Relevant log output

{
    "message": "Too few arguments to function Igniter\\Flame\\Database\\Pivot::__construct(), 0 passed in /var/www/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php on line 2099 and at least 3 expected",
    "status_code": 500,
    "debug": {
        "line": 46,
        "file": "/var/www/html/vendor/tastyigniter/flame/src/Database/Pivot.php",
        "class": "ArgumentCountError",
        "trace": [
            "#0 /var/www/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php(2099): Igniter\\Flame\\Database\\Pivot->__construct()",
            "#1 /var/www/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php(2066): Illuminate\\Database\\Eloquent\\Model::getAttributeMarkedMutatorMethods()",
            "#2 /var/www/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php(2051): Illuminate\\Database\\Eloquent\\Model::cacheMutatedAttributes()",
            "#3 /var/www/html/vendor/tastyigniter/flame/src/Database/Concerns/HasAttributes.php(78): Illuminate\\Database\\Eloquent\\Model->getMutatedAttributes()",
            "#4 /var/www/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php(1485): Igniter\\Flame\\Database\\Model->attributesToArray()",
            "#5 /var/www/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php(351): Illuminate\\Database\\Eloquent\\Model->toArray()",
            "#6 /var/www/html/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php(1485): Illuminate\\Database\\Eloquent\\Model->relationsToArray()",
            "#7 /var/www/html/extensions/igniter/api/apiresources/transformers/CategoryTransformer.php(18): Illuminate\\Database\\Eloquent\\Model->toArray()",
            "#8 /var/www/html/extensions/igniter/api/vendor/league/fractal/src/Scope.php(419): Igniter\\Api\\ApiResources\\Transformers\\CategoryTransformer->transform()",
            "#9 /var/www/html/extensions/igniter/api/vendor/league/fractal/src/Scope.php(361): League\\Fractal\\Scope->fireTransformer()",
            "#10 /var/www/html/extensions/igniter/api/vendor/league/fractal/src/Scope.php(235): League\\Fractal\\Scope->executeResourceTransformers()",
            "#11 /var/www/html/extensions/igniter/api/vendor/league/fractal/src/TransformerAbstract.php(162): League\\Fractal\\Scope->toArray()",
            "#12 /var/www/html/extensions/igniter/api/vendor/league/fractal/src/TransformerAbstract.php(128): League\\Fractal\\TransformerAbstract->includeResourceIfAvailable()",
            "#13 /var/www/html/extensions/igniter/api/vendor/league/fractal/src/Scope.php(447): League\\Fractal\\TransformerAbstract->processIncludedResources()",
            "#14 /var/www/html/extensions/igniter/api/vendor/league/fractal/src/Scope.php(423): League\\Fractal\\Scope->fireIncludedTransformers()",
            "#15 /var/www/html/extensions/igniter/api/vendor/league/fractal/src/Scope.php(361): League\\Fractal\\Scope->fireTransformer()",
            "#16 /var/www/html/extensions/igniter/api/vendor/league/fractal/src/Scope.php(235): League\\Fractal\\Scope->executeResourceTransformers()",
            "#17 /var/www/html/extensions/igniter/api/classes/FractalAdapter.php(51): League\\Fractal\\Scope->toArray()",
            "#18 /var/www/html/extensions/igniter/api/vendor/dingo/api/src/Transformer/Factory.php(77): Igniter\\Api\\Classes\\FractalAdapter->transform()",
            "#19 /var/www/html/extensions/igniter/api/vendor/dingo/api/src/Http/Response.php(136): Dingo\\Api\\Transformer\\Factory->transform()",
            "#20 /var/www/html/extensions/igniter/api/vendor/dingo/api/src/Routing/Router.php(560): Dingo\\Api\\Http\\Response->morph()",
            "#21 /var/www/html/extensions/igniter/api/vendor/dingo/api/src/Routing/Router.php(529): Dingo\\Api\\Routing\\Router->prepareResponse()",
            "#22 /var/www/html/extensions/igniter/api/vendor/dingo/api/src/Http/Middleware/Request.php(126): Dingo\\Api\\Routing\\Router->dispatch()",
            "#23 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(128): Dingo\\Api\\Http\\Middleware\\Request->Dingo\\Api\\Http\\Middleware\\{closure}()",
            "#24 /var/www/html/extensions/igniterlabs/visitortracker/middleware/TrackVisitor.php(13): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()",
            "#25 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): IgniterLabs\\VisitorTracker\\Middleware\\TrackVisitor->handle()",
            "#26 /var/www/html/vendor/tastyigniter/flame/src/Setting/Middleware/SaveSetting.php(27): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()",
            "#27 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Igniter\\Flame\\Setting\\Middleware\\SaveSetting->handle()",
            "#28 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()",
            "#29 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TrimStrings.php(40): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle()",
            "#30 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\TrimStrings->handle()",
            "#31 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()",
            "#32 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\ValidatePostSize->handle()",
            "#33 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php(86): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()",
            "#34 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\PreventRequestsDuringMaintenance->handle()",
            "#35 /var/www/html/vendor/fruitcake/laravel-cors/src/HandleCors.php(52): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()",
            "#36 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Fruitcake\\Cors\\HandleCors->handle()",
            "#37 /var/www/html/vendor/fideloper/proxy/src/TrustProxies.php(57): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()",
            "#38 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Fideloper\\Proxy\\TrustProxies->handle()",
            "#39 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()",
            "#40 /var/www/html/extensions/igniter/api/vendor/dingo/api/src/Http/Middleware/Request.php(127): Illuminate\\Pipeline\\Pipeline->then()",
            "#41 /var/www/html/extensions/igniter/api/vendor/dingo/api/src/Http/Middleware/Request.php(103): Dingo\\Api\\Http\\Middleware\\Request->sendRequestThroughRouter()",
            "#42 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Dingo\\Api\\Http\\Middleware\\Request->handle()",
            "#43 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()",
            "#44 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(142): Illuminate\\Pipeline\\Pipeline->then()",
            "#45 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(111): Illuminate\\Foundation\\Http\\Kernel->sendRequestThroughRouter()",
            "#46 /var/www/html/index.php(53): Illuminate\\Foundation\\Http\\Kernel->handle()",
            "#47 {main}"
        ]
    }
}

BaoNguyenSE · 2022-01-19T06:52:21Z

@ryanmitchell @sampoyigi please help me!

ryanmitchell · 2022-01-19T06:53:58Z

Please don't tag people like that. If it's urgent request support from the website, otherwise be patient as this is an open source mostly volunteer led project.

BaoNguyenSE · 2022-01-19T06:55:09Z

i so sorry.

ryanmitchell · 2022-01-19T08:54:11Z

I just ran a quick test and this works fine for me on 3.2 and the latest versions of all extensions. Can you make sure you're on the latest codebase and if so can you confirm what laravel and PHP versions you are using as there may be a clash there.

BaoNguyenSE · 2022-01-19T09:05:16Z

Im sure it latest codebase and Im using php version 7.4.26. and tasty v3.2.1. Thanks you for test.

ryanmitchell · 2022-01-19T09:08:12Z

Have you modified the codebase in any way?
What Laravel version is in your composer.lock file?

BaoNguyenSE · 2022-01-19T09:12:05Z

Im not modify any codebase. Im using laravelv8.0. Error happen when upgrade project to v 3.2.1

BaoNguyenSE · 2022-01-19T09:15:02Z

You haved create relation MenuItem to Categories, after i created relation it throw error.

ryanmitchell · 2022-01-19T09:25:01Z

Yes. I can see from your screenshot you have made modifications.... you have tax classes there

BaoNguyenSE · 2022-01-19T09:29:19Z

Tax Class is different extension.

ryanmitchell · 2022-01-19T09:51:08Z

I know, have you tried disabling it to see if thats the issue?

BaoNguyenSE · 2022-01-19T09:55:43Z

I just tried disabling the extension and the error still occurs.
Any api index have param include relationship one to many ex: categories, menus,...

BaoNguyenSE · 2022-01-19T10:03:18Z

this api get categories with include menus it happen same error

ryanmitchell · 2022-01-19T19:04:43Z

@sampoyigi any thoughts? Its working fine for me in all environments. Could it be a WAMP thing?

sampoyigi · 2022-01-19T20:55:38Z

I'm unable to reproduce the error, maybe try disabling all third party extensions?

BaoNguyenSE · 2022-01-20T01:05:26Z

What laravel version you use?

shomarim · 2022-01-25T14:53:34Z

I am also experiencing the same issue.
api/categories/4?include=locations works but
api/categories/4?include=menus does not

TastyIgniter 3.2.2
Laravel 8.80.0
PHP 8.0.12
MariaDB 10.3.32

BaoNguyenSE · 2022-01-26T01:58:47Z

@shomarim After many days debug, i found error occur on laravel 8.80, you can downgrade version to 8.74 to fix

shomarim · 2022-01-26T06:07:08Z

Thank you @BaoNguyenSE. That worked! I just tried different versions and it seems that the issue occurred with Laravel 8.77. I suspect this PR to be the cause: laravel/framework#40022

ryanmitchell · 2022-01-26T06:37:00Z

Thanks for investigating - yes it seems the upstream changes in Laravel have caused this.
@sampoyigi any thoughts on the right way to go about fixing this?

sampoyigi · 2022-02-08T13:15:46Z

@BaoNguyenSE thanks for investigating.

@shomarim can you please confirm if this issue still exists on laravel 8.80+, i'm unable to reproduce on 8.82

sampoyigi · 2022-02-15T15:08:21Z

Fixed here tastyigniter/flame@ad1dfc0

sampoyigi closed this as completed Feb 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: Throw error in GET list have parameter include is categories or menus #66

[Bug]: Throw error in GET list have parameter include is categories or menus #66

BaoNguyenSE commented Jan 18, 2022

BaoNguyenSE commented Jan 19, 2022

ryanmitchell commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022

ryanmitchell commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022 •

edited

Loading

ryanmitchell commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022 •

edited

Loading

ryanmitchell commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022

ryanmitchell commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022 •

edited

Loading

BaoNguyenSE commented Jan 19, 2022

ryanmitchell commented Jan 19, 2022

sampoyigi commented Jan 19, 2022

BaoNguyenSE commented Jan 20, 2022

shomarim commented Jan 25, 2022

BaoNguyenSE commented Jan 26, 2022

shomarim commented Jan 26, 2022

ryanmitchell commented Jan 26, 2022

sampoyigi commented Feb 8, 2022

sampoyigi commented Feb 15, 2022

[Bug]: Throw error in GET list have parameter include is categories or menus #66

[Bug]: Throw error in GET list have parameter include is categories or menus #66

Comments

BaoNguyenSE commented Jan 18, 2022

What happened?

What did you expect to happen?

Version

What browser are you seeing the problem on?

Relevant log output

BaoNguyenSE commented Jan 19, 2022

ryanmitchell commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022

ryanmitchell commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022 • edited Loading

ryanmitchell commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022 • edited Loading

ryanmitchell commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022

ryanmitchell commented Jan 19, 2022

BaoNguyenSE commented Jan 19, 2022 • edited Loading

BaoNguyenSE commented Jan 19, 2022

ryanmitchell commented Jan 19, 2022

sampoyigi commented Jan 19, 2022

BaoNguyenSE commented Jan 20, 2022

shomarim commented Jan 25, 2022

BaoNguyenSE commented Jan 26, 2022

shomarim commented Jan 26, 2022

ryanmitchell commented Jan 26, 2022

sampoyigi commented Feb 8, 2022

sampoyigi commented Feb 15, 2022

BaoNguyenSE commented Jan 19, 2022 •

edited

Loading

BaoNguyenSE commented Jan 19, 2022 •

edited

Loading

BaoNguyenSE commented Jan 19, 2022 •

edited

Loading