feat(telemetry): add option to omit context propagation #2946
Conversation
|
Wondering if an extra option can be passed at job level as for the case that was reportes, only repeatables jobs in some cases need this logic but we can keep the base logic for all the other job types |
In this particular case it was not really repeatable jobs, they were simulating repetition using custom code. However the point is valid, maybe it is better to have it as a per job config, worth to think more about it. |
|
I have changed it to pass the option entirely in bullmq, inside the job. For now only in methods regarding enhancement issue. |
…eat/telemetry-option-omit-context
src/classes/queue.ts
Outdated
| @@ -404,7 +404,10 @@ export class Queue< | |||
| ...this.jobsOpts, | |||
| ...job.opts, | |||
| jobId: job.opts?.jobId, | |||
| tm: span && srcPropagationMedatada, | |||
| tm: | |||
There was a problem hiding this comment.
I am confused, why is the option used here "tm" instead of "telemetryMetadata" as on the other functions above?
|
I will squash this PR as there were a few commits on this one... |
# [5.34.0](v5.33.1...v5.34.0) (2024-12-10) ### Features * **telemetry:** add option to omit context propagation on jobs ([#2946](#2946)) ([6514c33](6514c33))
ref #2942