Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(python): add Job.getChildrenValues #2853

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Arvinje
Copy link
Contributor

@Arvinje Arvinje commented Oct 22, 2024

Adds getChildrenValues method to the Python package's Job class, used to query returning values of child jobs

@Arvinje Arvinje marked this pull request as ready for review October 22, 2024 13:10
@@ -103,5 +104,75 @@ async def test_promote_delayed_job(self):

await queue.close()

async def test_get_children_values(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. done

@roggervalf roggervalf force-pushed the python/get-children-values branch from a3c63ba to 9f23bdb Compare October 23, 2024 05:17
@Arvinje Arvinje force-pushed the python/get-children-values branch from 9f23bdb to 7fa3ba7 Compare October 23, 2024 12:11
Adds getChildrenValues method to the Python package's Job class, used to query returning values of
child jobs
@Arvinje Arvinje force-pushed the python/get-children-values branch from 7fa3ba7 to 772a729 Compare October 23, 2024 12:49
@Arvinje Arvinje requested a review from roggervalf October 23, 2024 13:32
Copy link
Collaborator

@roggervalf roggervalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Thank you

@roggervalf roggervalf merged commit 0f25213 into taskforcesh:master Oct 24, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 31, 2024
# [5.22.0](v5.21.2...v5.22.0) (2024-10-31)

### Bug Fixes

* **commands:** add missing build statement when releasing [python] ([#2869](#2869)) fixes [#2868](#2868) ([ff2a47b](ff2a47b))

### Features

* **job:** add getChildrenValues method [python] ([#2853](#2853)) ([0f25213](0f25213))
* **queue:** add a telemetry interface ([#2721](#2721)) ([273b574](273b574))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants