fix(queue): get rid of repeat options from default #1284
Conversation
src/interfaces/jobs-options.ts
Outdated
| * The number of milliseconds after which the job should be | ||
| * fail with a timeout error. | ||
| */ | ||
| timeout?: number; |
There was a problem hiding this comment.
timeout, I think is not used, could I delete it?
There was a problem hiding this comment.
Not used. But I thinkn it is used in the Pro version. So we need to add it to Pro then.
src/interfaces/jobs-options.ts
Outdated
| * The number of milliseconds after which the job should be | ||
| * fail with a timeout error. | ||
| */ | ||
| timeout?: number; |
There was a problem hiding this comment.
Not used. But I thinkn it is used in the Pro version. So we need to add it to Pro then.
| /** | ||
| * Base repeat job key. | ||
| */ | ||
| repeatJobKey?: string; |
There was a problem hiding this comment.
Is this option really needed? I am thinking the user is not able to configure this key, it is computed automatically from the "repeat" option.
There was a problem hiding this comment.
yes, in this case is like prevMillis option, I'll change the description as prevMillis saying that this is an internal param
## [1.86.2](v1.86.1...v1.86.2) (2022-06-16) ### Bug Fixes * **queue:** get rid of repeat options from defaultJobOptions ([#1284](#1284)) ([cdd2a20](cdd2a20))
|
🎉 This PR is included in version 1.86.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
fixes #1282