diff --git a/src/classes/job.ts b/src/classes/job.ts index ddbeb9c172..0d1dcc4c17 100644 --- a/src/classes/job.ts +++ b/src/classes/job.ts @@ -1141,10 +1141,7 @@ export class Job< } if (`${parseInt(this.id, 10)}` === this.id) { - //TODO: throw an error in next breaking change - console.warn( - 'Custom Ids should not be integers: https://github.com/taskforcesh/bullmq/pull/1569', - ); + throw new Error('Custom Ids cannot be integers'); } if (this.opts.priority) { diff --git a/tests/test_queue.ts b/tests/test_queue.ts index d765f57a8f..491d709ded 100644 --- a/tests/test_queue.ts +++ b/tests/test_queue.ts @@ -36,8 +36,7 @@ describe('queues', function () { await connection.quit(); }); - //TODO: restore this tests in next breaking change - describe.skip('.add', () => { + describe('.add', () => { describe('when jobId is provided as integer', () => { it('throws error', async function () { await expect(