Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change font family to monospace on the left panel #122

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Change font family to monospace on the left panel #122

merged 1 commit into from
Nov 18, 2020

Conversation

Joaquin-M2
Copy link
Contributor

Goal

Change the font family of the left panel (Schema Table component) to "monospace".

Closes #115 .

@djmitche, @helfi92, please, check if the font size looks fine to you.

Todos:

  • Change the font family property of the names of the schemas to monospace;
  • Change the font family property of the types of the schemas to monospace.

Implementation Decisions

I modified the "fontFamily" property on the "name" and "code" class names (in the "makeStyles()" Material-UI function, which starts on line 22 from LeftCell.jsx).

@djmitche djmitche self-requested a review November 18, 2020 18:24
Copy link
Contributor

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better to my untrained eye :)

@djmitche djmitche merged commit 6acffb7 into taskcluster:main Nov 18, 2020
@Joaquin-M2 Joaquin-M2 deleted the monospace-font branch November 18, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a monospace font on the left side
2 participants