Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't update issue on redmine 4.1.0.stable #348

Open
marepop opened this issue Apr 16, 2020 · 5 comments
Open

Can't update issue on redmine 4.1.0.stable #348

marepop opened this issue Apr 16, 2020 · 5 comments

Comments

@marepop
Copy link

marepop commented Apr 16, 2020

Hi, i cannot update the issue using either fluent API or via transport. The error is "Entity may not be null". There is no entity since this response from Redmine returns a 204 no content (no body) but Apache still throws this error.
Any way to resolve this? issue.update() and t.updateObject(issue) both throw the same thing.

Error happens here:
return handler.processContent(httpResponse);
because final String charset = HttpUtil.getCharset(entity); is called on null entity.

Originally posted by @marepop in #342 (comment)

@alexeyOnGitHub
Copy link
Member

let's clarify - so this works with older Redmine versions, but does not work with Redmine 4.1.0.stable. is that correct?

@marepop
Copy link
Author

marepop commented Apr 16, 2020

let's clarify - so this works with older Redmine versions, but does not work with Redmine 4.1.0.stable. is that correct?

Yes. That's correct. Our implementation worked with an older version of Redmine. After migrating to a new version 4.1.0.stable (no additional plugins) i came upon this problem.

@alexeyOnGitHub
Copy link
Member

alright, can you please run all tests in this project against your own Redmine instance and see what else fails? (see redmine server URL in config files).

you are welcome to explore what API changes are required to support Redmine 4.1.0.stable and submit a proposal along with a PR.

@haiyanghaiyang
Copy link

I've created a PR: #355
I don't know how to run the test. But I got it works with Gerrit its-redmine plugin with Redmine 4.1.1. Please have a try.

@alexeyOnGitHub
Copy link
Member

you can change the test config to point to your local Redmine instance and then run "gradle test".
please ensure that the change works with the non-modded Redmine installation (no extra plugins). you may need to write some additional tests to cover this specific use-case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants