Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter limit and offset are overwritten in Transport.getObjectsList() #181

Closed
a11n opened this issue Mar 10, 2015 · 1 comment
Closed

Parameter limit and offset are overwritten in Transport.getObjectsList() #181

a11n opened this issue Mar 10, 2015 · 1 comment
Labels
duplicate

Comments

@a11n
Copy link
Contributor

a11n commented Mar 10, 2015

Problem
For IssueManager.getIssues(Map<String, String> pParameters) the documentation mentions:

@param pParameters the http parameters key/value pairs to append to the rest api request

When setting offset and limitlike described in official Redmine documentation these two parameters are ignored.

Reason
They are overwritten in Transport.getObjectsList() (line 413 and line 421)

Suggestion
A quick aid would be to mention this in the Javadoc of getIssues(). A more complex solution would be to ignore them if set in provided parameters. These would give redmine-java-api users more control, e.g. for implementing paging.

What do you think? Just tell me what you prefer, I could contribute an according pull request.
@alexeyOnGitHub
Copy link
Member

this is a duplicate of #114
feel free to fix this

@a11n a11n mentioned this issue Mar 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexeyOnGitHub @a11n