fix: use mined at timestamp in fauxconfirmation #5443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing 0 every time when we should have been using the mined at timestamp.
ghpbot-tari-project
added
the
P-acks_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We were passing 0 every time when we should have been using the mined at timestamp.
Motivation and Context
Once unconfirmed one sided transactions had been confirmed we were dropping the proper mined at timestamp.
How Has This Been Tested?
Locally with one sided, and one sided stealth transactions between local wallets on igor.
What process can a PR reviewer use to test or verify this change?
Receive a one sided TX, and validate the mined at timestamp is present once confirmed.
Closes: #5167
Breaking Changes