fix(wallet-ffi): don't block on start #5437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the ffi call to create and start the wallet will block until connections have been made. Instead return the Wallet asap, and throw the previously blocking call into an async non blocking call and let it complete on its own time.
brianp
changed the title
ghpbot-tari-project
added
P-acks_required
4 tasks
stringhandler
approved these changes
Jun 6, 2023
ghpbot-tari-project
removed
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the ffi call to create and start the wallet will block until connections have been made. Instead return the Wallet asap, and throw the previously blocking call into an async non blocking call and let it complete on its own time.
Motivation and Context
The wallet freezes up for a duration while connecting to tor and the base node if the user has low connectivity. This prevents all other local actions from functioning. Instead we can return an initialized wallet that doesn't have connectivity allowing for local manipulation and gain connectivity in the background.
How Has This Been Tested?
CI only
What process can a PR reviewer use to test or verify this change?
Watch for green checks
Breaking Changes