docs: add range proof verification warnings #5412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
This is superseded by #5411, which adds an internal signature check to range proof verification just to be safe. |
ghpbot-tari-project
added
P-acks_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds warning comments about revealed-value range proof verification to help guard against misuse.
Motivation and Context
As noted in a comment on #5372, verification of a revealed-value range proof requires separate verification of the corresponding metadata signature. Without such a check, range proof verification is inconclusive.
Because this is a major but subtle change to the guarantees provided by the single and batch range proof verification functions, this PR adds scary warning comments .
How Has This Been Tested?
The comments look sufficiently frightening.
What process can a PR reviewer use to test or verify this change?
Ensure that there are no code paths that assume revealed-value range proof validity without metadata signature verification.