feat: define different network defaults for bins #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
previously approved these changes
Apr 12, 2023
ghpbot-tari-project
added
the
P-acks_required
|
utAck |
This commit make a simple switch to define Network::default differently for the different bins compiled for different networks. Making us one step closer to smarter defaults, and one click, out of the box.
brianp
force-pushed
the
feature-default-network-switch
branch
from
940ee73
to
3180efb
Compare
ghpbot-tari-project
added
the
P-reviews_required
ghpbot-tari-project
removed
the
P-reviews_required
SWvheerden
added a commit
that referenced
this pull request
Apr 12, 2023
## [0.50.0-pre.0](v0.49.0-pre.6...v0.50.0-pre.0) (2023-04-12) ### ⚠ BREAKING CHANGES * add paging to utxo stream request (5302) ### Features * add extended mask recovery ([5301](#5301)) ([23d882e](23d882e)) * add network name to data path and --network flag to the miners ([5291](#5291)) ([1f04beb](1f04beb)) * add other code template types ([5242](#5242)) ([93e5e85](93e5e85)) * add paging to utxo stream request ([5302](#5302)) ([3540309](3540309)) * add wallet daemon config ([5311](#5311)) ([30419cf](30419cf)) * define different network defaults for bins ([5307](#5307)) ([2f5d498](2f5d498)) * feature gates ([5287](#5287)) ([72c19dc](72c19dc)) * fix rpc transaction conversion ([5304](#5304)) ([344040a](344040a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit make a simple switch to define Network::default differently for the different bins compiled for different networks.
Motivation and Context
Making us one step closer to smarter defaults, and one click, out of the box.
How Has This Been Tested?
Manually
What process can a PR reviewer use to test or verify this change?
Compile the bin with
TARI_NETWORK=...then validate the bin uses the correct defaultFixes: #5310
Breaking Changes