feat!: add paging to utxo stream request #5302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an alternative to PR #5298 The issue we have is that the Genesis block has too many utxos to send over the wire with the 4mb size limit. |
ghpbot-tari-project
added
P-acks_required
4 tasks
SWvheerden
changed the title
hansieodendaal
previously approved these changes
Apr 11, 2023
| // Ensure task stops if the peer prematurely stops their RPC session | ||
| if tx.send(Ok(utxo_block_response)).await.is_err() { | ||
| break; | ||
| for utxo_chunk in utxos.chunks(2000) { |
There was a problem hiding this comment.
We can safely increase this number to 4000 as 5526 UTXOs in the faucet takes up approximately 4.5924 MiB. Thus (4000 / 5526) x 4.5924 = 3.3242 MiB.
ghpbot-tari-project
removed
P-reviews_required
SWvheerden
force-pushed
the
sw_paging_request
branch
from
fa0746c
to
f413b89
Compare
hansieodendaal
previously approved these changes
Apr 11, 2023
stringhandler
approved these changes
Apr 12, 2023
SWvheerden
added a commit
that referenced
this pull request
Apr 12, 2023
## [0.50.0-pre.0](v0.49.0-pre.6...v0.50.0-pre.0) (2023-04-12) ### ⚠ BREAKING CHANGES * add paging to utxo stream request (5302) ### Features * add extended mask recovery ([5301](#5301)) ([23d882e](23d882e)) * add network name to data path and --network flag to the miners ([5291](#5291)) ([1f04beb](1f04beb)) * add other code template types ([5242](#5242)) ([93e5e85](93e5e85)) * add paging to utxo stream request ([5302](#5302)) ([3540309](3540309)) * add wallet daemon config ([5311](#5311)) ([30419cf](30419cf)) * define different network defaults for bins ([5307](#5307)) ([2f5d498](2f5d498)) * feature gates ([5287](#5287)) ([72c19dc](72c19dc)) * fix rpc transaction conversion ([5304](#5304)) ([344040a](344040a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds paging to the utxo stream to handle the large amount of faucet utxos
Motivation and Context
See: #5299
How Has This Been Tested?
unit tests
Fixes: #5299
What process can a PR reviewer use to test or verify this change?
See PR #5298
Breaking Changes
Changes request service