feat: improved passphrase flow #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
password-confirm
branch
from
9e10ba9
to
19e140e
Compare
AaronFeickert
force-pushed
the
password-confirm
branch
from
19e140e
to
6097c4c
Compare
ghpbot-tari-project
added
P-acks_required
SWvheerden
reviewed
Mar 29, 2023
SWvheerden
approved these changes
Mar 29, 2023
ghpbot-tari-project
removed
the
P-reviews_required
|
ACK |
ghpbot-tari-project
removed
the
P-acks_required
agubarev
pushed a commit
to agubarev/tari
that referenced
this pull request
Mar 31, 2023
Description --- Improves the flow for setting or changing a passphrase. Closes [issue 5127](tari-project#5127). Motivation and Context --- When setting or [changing](tari-project#5175) a wallet passphrase, the console wallet provides [feedback](tari-project#5111) on the strength of the provided passphrase. In the case of a weak passphrase, it does not prompt the user to choose a better one. This PR implements a better flow for this process, as shown in [this flowchart](tari-project#5127 (comment)). How Has This Been Tested? --- Tested manually. What process can a PR reviewer use to test or verify this change? --- Testing needs to be done manually to assert that the process represented by the linked flowchart is implemented. Manual testing should cover the entire flow for these two operations: - Setting the passphrase for a new wallet - Changing the passphrase for an existing wallet Breaking Changes --- None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the flow for setting or changing a passphrase.
Closes issue 5127.
Motivation and Context
When setting or changing a wallet passphrase, the console wallet provides feedback on the strength of the provided passphrase. In the case of a weak passphrase, it does not prompt the user to choose a better one.
This PR implements a better flow for this process, as shown in this flowchart.
How Has This Been Tested?
Tested manually.
What process can a PR reviewer use to test or verify this change?
Testing needs to be done manually to assert that the process represented by the linked flowchart is implemented. Manual testing should cover the entire flow for these two operations:
Breaking Changes
None.