fix: added transaction revalidation to the wallet startup sequence #5227 #5246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubarev
changed the title
stringhandler
pushed a commit
that referenced
this pull request
Mar 15, 2023
### ⚠ BREAKING CHANGES * **wallet:** ensure burn shared keys and hashes match dan layer (5245) * add claim public key to OutputFeatures (5239) * reset esmeralda (5247) ### Features * add claim public key to OutputFeatures ([5239](#5239)) ([3e7d82c](3e7d82c)) * reset esmeralda ([5247](#5247)) ([aa2a3ad](aa2a3ad)) ### Bug Fixes * added transaction revalidation to the wallet startup sequence [5227](#5227) ([5246](#5246)) ([7b4e2d2](7b4e2d2)) * immediately fail to compile on 32-bit systems ([5237](#5237)) ([76aeed7](76aeed7)) * **wallet:** correct change checks in transaction builder ([5235](#5235)) ([768a0cf](768a0cf)) * **wallet:** ensure burn shared keys and hashes match dan layer ([5245](#5245)) ([024ce64](024ce64)) * windows path format in log4rs files ([5234](#5234)) ([acfecfb](acfecfb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now wallet revalidates all transactions included in the wallet on startup.
#5227
Motivation and Context
Outputs fetched from a fully synced node could be invalidated by the transaction validator, e.g. wallet has normal outputs,
fully validated, but at some point become invalidated when the wallet is trying to negotiate with another, not yet fully synced node that doesn't recognise said output due to not reaching its height at the moment.
So, the code was already there but not yet used in the startup process.
How Has This Been Tested?
manually