fix: feature flag separation for validation #5137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leet4tari
reviewed
Jan 24, 2023
SWvheerden
force-pushed
the
sw_refactor_features
branch
3 times, most recently
from
25b8887
to
d358a3e
Compare
There was a problem hiding this comment.
Agree with the idea, but there are too many cfg's here. It's a recipe for dev mistakes and it's not clear when it needs to be applied versus not. I can see someone just adding #cfg[base_node] to every method.
Is there not a way we can group it all of this together under a common crate or file?
SWvheerden
force-pushed
the
sw_refactor_features
branch
from
d358a3e
to
e245adc
Compare
SWvheerden
added
A-base_node
SWvheerden
force-pushed
the
sw_refactor_features
branch
from
b1fad3d
to
38a06a8
Compare
remove base_node from wallet_ffi
SWvheerden
force-pushed
the
sw_refactor_features
branch
from
c96c385
to
2cba74a
Compare
stringhandler
approved these changes
Feb 1, 2023
|
Just waiting for CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes OpenSSL from the WalletFFI lib as its not required or used by it.
Fixes validation feature flags.
Motivation and Context
Recent refactor added
base_nodefeature flag to the walletFFI. This should not be done as it adds in all the base nodespecific crates that not required by the wallet like randomX, lmdb etc.
This splits the validation traits and implementations between the features
transactionsandbase_node.How Has This Been Tested?
Manual and unit tests
Fixes: #4974