Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleted_txo_mmr_position_to_height_index already exists error #4924

Merged
merged 4 commits into from
Nov 22, 2022

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Nov 15, 2022

Description

Fixes deleted_txo_mmr_position_to_height_index already exists error
Adds in a unit test for the testing zero_conf with a re_org

How Has This Been Tested?

Add a unit test

Fixes: #4833

stringhandler
stringhandler previously approved these changes Nov 15, 2022
@SWvheerden SWvheerden marked this pull request as draft November 16, 2022 06:21
@SWvheerden SWvheerden changed the title test: add reorg test for zero_conf fix: deleted_txo_mmr_position_to_height_index already exists error Nov 16, 2022
@SWvheerden SWvheerden marked this pull request as ready for review November 16, 2022 15:33
@sdbondi sdbondi added the P-conflicts Process - The PR has merge conflicts that need to be resolved label Nov 18, 2022
sdbondi
sdbondi previously approved these changes Nov 18, 2022
Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, makes sense

stringhandler
stringhandler previously approved these changes Nov 18, 2022
@sdbondi sdbondi removed the P-conflicts Process - The PR has merge conflicts that need to be resolved label Nov 21, 2022
@sdbondi sdbondi merged commit 0269f11 into tari-project:development Nov 22, 2022
sdbondi added a commit to sdbondi/tari that referenced this pull request Nov 23, 2022
* development:
  fix: add hidden types and seed words to key manager (tari-project#4925)
  feat: timestamp validation (tari-project#4887)
  fix: deleted_txo_mmr_position_to_height_index  already exists error (tari-project#4924)
  feat: add default grpc for localnet (tari-project#4937)
  first commit (tari-project#4926)
  v0.40.2
  fix(dht): use limited ban period for invalid peer (tari-project#4933)
  feat: upgrade tari_crypto sign api (tari-project#4932)
  v0.40.1
  chore: fix depreciated timestamp clippy (tari-project#4929)
  chore: fix naming of ffi functions and comments  (tari-project#4930)
  fix: set wallet start scan height to birthday and not 0 (see issue tari-project#4807) (tari-project#4911)
  v0.40.0
  chore: remove unused methods (tari-project#4922)
  fix: updates for SafePassword API change (tari-project#4927)
@SWvheerden SWvheerden deleted the sw_add_reorg_test branch November 24, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyExists error "deleted_txo_mmr_position_to_height_index"
3 participants