Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set wallet start scan height to birthday and not 0 (see issue #4807) #4911

Merged
merged 12 commits into from
Nov 16, 2022
Merged

fix: set wallet start scan height to birthday and not 0 (see issue #4807) #4911

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f4fe6d9
first commit
jorgeantonio21 Nov 11, 2022
b27c1da
add changes
jorgeantonio21 Nov 15, 2022
eaf1ef6
add birthday from unix epoch util function
jorgeantonio21 Nov 15, 2022
116e5eb
refactor calculation of birthday epoch time
jorgeantonio21 Nov 15, 2022
3423edd
correct tests
jorgeantonio21 Nov 15, 2022
249ebf1
Merge branch 'development' into ja-wallet-scans-at-birthday-not-height-0
jorgeantonio21 Nov 15, 2022
763e243
take 14 days back from birthday to account for reorgs
jorgeantonio21 Nov 15, 2022
85de3b0
Merge branch 'development' into ja-wallet-scans-at-birthday-not-height-0
jorgeantonio21 Nov 16, 2022
f57c801
add PR changes
jorgeantonio21 Nov 16, 2022
7d96727
Merge branch 'development' into ja-wallet-scans-at-birthday-not-height-0
jorgeantonio21 Nov 16, 2022
9262b5d
add test birthday timestamp over chain
jorgeantonio21 Nov 16, 2022
2eaae5d
good practices
jorgeantonio21 Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion base_layer/wallet/src/utxo_scanner_service/utxo_scanner_task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,11 @@ where
client: &mut BaseNodeWalletRpcClient,
) -> Result<BlockHeader, UtxoScannerError> {
let tip_info = client.get_tip_info().await?;
let chain_height = tip_info.metadata.map(|m| m.height_of_longest_chain()).unwrap_or(0);
let wallet_birthday_height = self.get_birthday_header_height_hash(client).await?.height;
jorgeantonio21 marked this conversation as resolved.
Show resolved Hide resolved
let chain_height = tip_info
.metadata
.map(|m| m.height_of_longest_chain())
.unwrap_or(wallet_birthday_height);
let end_header = client.get_header_by_height(chain_height).await?;
let end_header = BlockHeader::try_from(end_header).map_err(UtxoScannerError::ConversionError)?;

Expand Down